Skip to content

include as identity in wallet to handle sessions#2152

Merged
scguaquetam merged 1 commit into
v1.21.0from
feat/posthog_session
Jun 23, 2026
Merged

include as identity in wallet to handle sessions#2152
scguaquetam merged 1 commit into
v1.21.0from
feat/posthog_session

Conversation

@sleyter93

Copy link
Copy Markdown
Collaborator

No description provided.

@sleyter93 sleyter93 requested a review from scguaquetam June 3, 2026 14:59
@sleyter93 sleyter93 self-assigned this Jun 3, 2026
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

wallet_address: address.toLowerCase(),
$set_once: { first_seen: new Date().toISOString() },
})
posthog.register({ wallet_address: address.toLowerCase(), user_type: 'wallet' })

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we will manage this way the identity of the users, what should we do with the Super Property added in the file src/shared/walletConnection/PostHogWalletSync.tsx and the correspondent logout src/shared/walletConnection/connection/DisconnectWorkflowContainer.tsx

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep it and add it specifically so we can join it with the sessions already tracked in PostHog.

If we don't identify the user when they connect their wallet, we'll end up with a number of visits/sessions on one side and wallet-related events on the other, without a reliable way to connect them. That would make it difficult to answer questions such as how many visitors actually connected their wallet or what actions they took before doing so.

At the moment, we're mainly tracking events when a user performs an action (e.g., vote, delegate), not necessarily when they are only browsing or viewing content. Having this super property tied to the user's identity allows us to connect those anonymous sessions with their wallet activity later and get a much clearer view of the user journey and conversion funnel.

@sleyter93 sleyter93 marked this pull request as ready for review June 23, 2026 04:47
@scguaquetam scguaquetam merged commit b0753ff into v1.21.0 Jun 23, 2026
4 checks passed
@scguaquetam scguaquetam deleted the feat/posthog_session branch June 23, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants